Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: avoid using columnEvaluator for the Projectin build by buildProjtion4Union (#8142) #8165

Merged
merged 3 commits into from
Nov 5, 2018
Merged

*: avoid using columnEvaluator for the Projectin build by buildProjtion4Union (#8142) #8165

merged 3 commits into from
Nov 5, 2018

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Nov 5, 2018

cherry-pick #8142

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Nov 5, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason
Copy link
Member

zz-jason commented Nov 5, 2018

LGTM

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Nov 5, 2018
@zz-jason
Copy link
Member

zz-jason commented Nov 5, 2018

@winoros @lamxTyler @eurekaka PTAL

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Nov 5, 2018

@winoros @lamxTyler @eurekaka PTAL

winoros
winoros approved these changes Nov 5, 2018
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 5, 2018
@zz-jason zz-jason merged commit 5bfe2fe into pingcap:release-2.1 Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuHuaiyu @zz-jason @winoros